revert 0x enhancements: v1 fills and deduped #7186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RantumBits i need to revert these two PR commits. it's failing on rebuild in prod due to
volume_usd
column renamed toamount_usd
, since you use theadd_amount_usd
macro for prices now.i also noticed base chain api fills was writing 0 rows (also happened in CI, we just missed it i guess). reference:
https://github.com/duneanalytics/spellbook/actions/runs/11957010061/job/33333123315#step:12:19